hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5542) Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
Date Fri, 09 Mar 2012 01:05:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225757#comment-13225757
] 

Phabricator commented on HBASE-5542:
------------------------------------

tedyu has commented on the revision "HBASE-5542 [jira] Unify HRegion.mutateRowsWithLocks()
and HRegion.processRow()".

  Thanks for the fast turn-around.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java:35 Add
javadoc for this class, please.
  src/main/java/org/apache/hadoop/hbase/regionserver/MultiRowMutationProcessor.java:85 We
can store m.getWriteToWAL() in a boolean before entering the loop and use the boolean variable,
right ?

REVISION DETAIL
  https://reviews.facebook.net/D2217

                
> Unify HRegion.mutateRowsWithLocks() and HRegion.processRow()
> ------------------------------------------------------------
>
>                 Key: HBASE-5542
>                 URL: https://issues.apache.org/jira/browse/HBASE-5542
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: HBASE-5542.D2217.1.patch
>
>
> mutateRowsWithLocks() does atomic mutations on multiple rows.
> processRow() does atomic read-modify-writes on a single row.
> It will be useful to generalize both and have a
> processRowsWithLocks() that does atomic read-modify-writes on multiple rows.
> This also helps reduce some redundancy in the codes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message