hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5584) Coprocessor hooks can be called in the respective handlers
Date Fri, 16 Mar 2012 04:30:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230889#comment-13230889
] 

ramkrishna.s.vasudevan commented on HBASE-5584:
-----------------------------------------------

@Mingjie/Andrew

Thanks for your reply. 
bq.Would adding additional hooks for handler actions work for you here?
Yes it would work.  We can strengthen the client that we write to see if all the needed tables
are created or not.  Atleast the change that we do will avoid unnecessary waiting logics added
in the current hooks.

Currently create, enable, disable, modify and delete,  are done in async mode.  
Modifycolumn, deletecolumn all are sync.  But still can we go ahead an add hooks in those
Handlers also so that in future it may be needed.

Can we name the new hooks as preXXXhandler and postXXXhandler?
Please do suggest if the above is ok..I can submit a patch for the same.
                
> Coprocessor hooks can be called in the respective handlers
> ----------------------------------------------------------
>
>                 Key: HBASE-5584
>                 URL: https://issues.apache.org/jira/browse/HBASE-5584
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.96.0
>
>
> Following points can be changed w.r.t to coprocessors
> -> Call preCreate, postCreate, preEnable, postEnable, etc. in their respective handlers
> -> Currently it is called in the HMaster thus making the postApis async w.r.t the
handlers
> -> Similar is the case with the balancer.
> with current behaviour once we are in the postEnable(for eg) we any way need to wait
for the main enable handler to 
> be completed.
> We should ensure that we dont wait in the main thread so again we need to spawn a thread
and wait on that.
> On the other hand if the pre and post api is called on the handlers then only that handler
thread will be
> used in the pre/post apis
> If the above said plan is ok i can prepare a patch for all such related changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message