Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 29 Feb 2012 16:53:57 +0000 (UTC)
From: "Zhihong Yu (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <934640933.3572.1330534437252.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1735060176.3444.1330531917018.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5491) Delete the
 HBaseConfiguration.create for coprocessor.Exec class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219338#comment-13219338 ] 

Zhihong Yu commented on HBASE-5491:
-----------------------------------

The default Exec ctor is only used by TestCoprocessorEndpoint
I think we shouldn't introduce public method(s) just for unit tests.
Stack's last comment makes sense.

@Honghai:
Can you attach a new patch ?
                
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
>                 Key: HBASE-5491
>                 URL: https://issues.apache.org/jira/browse/HBASE-5491
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors
>    Affects Versions: 0.92.0
>         Environment: all
>            Reporter: honghua zhu
>             Fix For: 0.92.1
>
>         Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira