Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 48F66981B for ; Fri, 17 Feb 2012 23:50:22 +0000 (UTC) Received: (qmail 21076 invoked by uid 500); 17 Feb 2012 23:50:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 21030 invoked by uid 500); 17 Feb 2012 23:50:22 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 21018 invoked by uid 99); 17 Feb 2012 23:50:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2012 23:50:22 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2012 23:50:20 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C93071BD5D9 for ; Fri, 17 Feb 2012 23:50:00 +0000 (UTC) Date: Fri, 17 Feb 2012 23:50:00 +0000 (UTC) From: "Phabricator (Updated) (JIRA)" To: issues@hbase.apache.org Message-ID: <632039331.52681.1329522600825.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1326197391.10213.1328316713888.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HBASE-5332) Deterministic Compaction Jitter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phabricator updated HBASE-5332: ------------------------------- Attachment: D1785.1.patch nspiegelberg requested code review of "[jira] [HBASE-5332] Deterministic Compaction Jitter". Reviewers: JIRA, Kannan, aaiyer, stack Changing the jitter in major compactions to be deterministic, so reboots don't cause a time-based compaction storm. This implementation seeds a random number generator with HDFS data for persistence. TEST PLAN - mvn test -Dtest=TestCompaction,TestCompactSelection,TestHeapSize REVISION DETAIL https://reviews.facebook.net/D1785 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/regionserver/Store.java src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactSelection.java src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/3807/ Tip: use the X-Herald-Rules header to filter Herald messages in your client. > Deterministic Compaction Jitter > ------------------------------- > > Key: HBASE-5332 > URL: https://issues.apache.org/jira/browse/HBASE-5332 > Project: HBase > Issue Type: Improvement > Reporter: Nicolas Spiegelberg > Assignee: Nicolas Spiegelberg > Priority: Minor > Attachments: D1785.1.patch > > > Currently, we add jitter to a compaction using "delay + jitter*(1 - 2*Math.random())". Since this is non-deterministic, we can get major compaction storms on server restart as half the Stores that were set to "delay + jitter" will now be set to "delay - jitter". We need a more deterministic way to jitter major compactions so this information can persist across server restarts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira