Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2FD0F983A for ; Thu, 2 Feb 2012 02:56:23 +0000 (UTC) Received: (qmail 97392 invoked by uid 500); 2 Feb 2012 02:56:22 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 97128 invoked by uid 500); 2 Feb 2012 02:56:21 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 96985 invoked by uid 99); 2 Feb 2012 02:56:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2012 02:56:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2012 02:56:14 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CCF5518662E for ; Thu, 2 Feb 2012 02:55:54 +0000 (UTC) Date: Thu, 2 Feb 2012 02:55:54 +0000 (UTC) From: "Phabricator (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <393348147.1163.1328151354841.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1623826033.35616.1326396879448.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5186) Add metrics to ThriftServer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198498#comment-13198498 ] Phabricator commented on HBASE-5186: ------------------------------------ tedyu has commented on the revision "HBASE-5186 [jira] Add metrics to ThriftServer". INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:131 I searched HBase code base and didn't find any call to drainTo(). For simplicity and correctness, I think patch v8 looks better. If drainTo() becomes performance bottleneck, we can come back optimizing it. REVISION DETAIL https://reviews.facebook.net/D1461 > Add metrics to ThriftServer > --------------------------- > > Key: HBASE-5186 > URL: https://issues.apache.org/jira/browse/HBASE-5186 > Project: HBase > Issue Type: Improvement > Reporter: Scott Chen > Assignee: Scott Chen > Attachments: 5186-v10.txt, 5186-v11.txt, 5186-v9.txt, HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, HBASE-5186.D1461.3.patch, HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch, HBASE-5186.D1461.6.patch, HBASE-5186.D1461.7.patch, HBASE-5186.D1461.8.patch > > > It will be useful to have some metrics (queue length, waiting time, processing time ...) similar to Hadoop RPC server. This allows us to monitor system health also provide a tool to diagnose the problem where thrift calls are slow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira