Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 13 Feb 2012 21:29:06 +0000 (UTC)
From: "Zhihong Yu (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <307331926.33568.1329168546311.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <578467854.29508.1329054539469.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5388) Tuning
 HConnectionManager#getCachedLocation method
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207226#comment-13207226 ] 

Zhihong Yu commented on HBASE-5388:
-----------------------------------

The new method, lowerValueByKey(), isn't in NavigableMap.
If we restrict SoftValueSortedMap to only implementing NavigableMap, where should we place lowerValueByKey() ?
I assume we may find other place(s) in our code which can reuse lowerValueByKey().
                
> Tuning HConnectionManager#getCachedLocation method
> --------------------------------------------------
>
>                 Key: HBASE-5388
>                 URL: https://issues.apache.org/jira/browse/HBASE-5388
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.5
>            Reporter: ronghai.ma
>            Assignee: ronghai.ma
>              Labels: patch
>             Fix For: 0.94.0
>
>         Attachments: 5388-v2.txt, 5388-v3.txt, HConnectionManager.java, SoftValueSortedMap.java, SoftValueSortedMap.java
>
>
> About 75% improvement in execution time.
> 1. Add the following method in SoftValueSortedMap:
> {code}
> public synchronized <K, V> Entry<K, V> lowerEntry(K key) {
>   return ((TreeMap) this.internalMap).lowerEntry(key);
> }
> {code}
> 2. Modify getCachedLocation:
> {code} 
> Map.Entry<byte[], HRegionLocation> tEntry = tableLocations.lowerEntry(row);
>   if (tEntry != null) {
>   HRegionLocation possibleRegion = tEntry.getValue();
>   //other code
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira