Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 8 Feb 2012 05:52:59 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <267037085.13390.1328680379258.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2100625119.7041.1327918390216.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5298) Add thrift metrics to thrift2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203298#comment-13203298 ] 

Hadoop QA commented on HBASE-5298:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12513760/5298-v3.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 9 new or modified tests.

    -1 javadoc.  The javadoc tool appears to have generated -136 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestHFileBlock
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/921//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/921//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/921//console

This message is automatically generated.
                
> Add thrift metrics to thrift2
> -----------------------------
>
>                 Key: HBASE-5298
>                 URL: https://issues.apache.org/jira/browse/HBASE-5298
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics, thrift
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: 5298-v3.txt, HBASE-5298.D1629.1.patch, HBASE-5298.D1629.2.patch
>
>
> We have added thrift metrics collection in HBASE-5186.
> It will be good to have them in thrift2 as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira