Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Feb 2012 06:51:54 +0000 (UTC)
From: "Lars Hofhansl (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <145342486.1515.1328165514401.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-3134) [replication] Add the ability to
 enable/disable streams
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198567#comment-13198567 ] 

Lars Hofhansl commented on HBASE-3134:
--------------------------------------

Nit: In the test:
{code}
+    for (int i = 0; i < NB_RETRIES; i++) {
+      if (i == NB_RETRIES - 1) {
+        break;
+      }
{code}
It is equivalent to 
{code}
for (int i = 0; i < NB_RETRIES-1; i++)
{code}
And since we're just waiting for some to make sure that nothing was replicated, might as well go 'round one more time and just remove the if statement.

Also this will always wait for 5s (not a big deal but would be nice to avoid this somehow).

TestReplication.testStartStop() does exactly the same, though.

+1 otherwise
                
> [replication] Add the ability to enable/disable streams
> -------------------------------------------------------
>
>                 Key: HBASE-3134
>                 URL: https://issues.apache.org/jira/browse/HBASE-3134
>             Project: HBase
>          Issue Type: New Feature
>          Components: replication
>            Reporter: Jean-Daniel Cryans
>            Assignee: Teruyoshi Zenmyo
>            Priority: Minor
>              Labels: replication
>             Fix For: 0.94.0
>
>         Attachments: HBASE-3134.patch, HBASE-3134.patch
>
>
> This jira was initially in the scope of HBASE-2201, but was pushed out since it has low value compared to the required effort (and when want to ship 0.90.0 rather soonish).
> We need to design a way to enable/disable replication streams in a determinate fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira