Return-Path: 
 <issues-return-34979-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C89DF9A67
	for <apmail-hbase-issues-archive@www.apache.org>;
 Wed,  8 Feb 2012 23:29:24 +0000 (UTC)
Received: (qmail 4686 invoked by uid 500); 8 Feb 2012 23:29:24 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 4588 invoked by uid 500); 8 Feb 2012 23:29:24 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 4580 invoked by uid 99); 8 Feb 2012 23:29:24 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2012 23:29:23 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2012 23:29:21 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 7B36B1ABFC0
	for <issues@hbase.apache.org>; Wed,  8 Feb 2012 23:29:00 +0000 (UTC)
Date: Wed, 8 Feb 2012 23:29:00 +0000 (UTC)
From: "Todd Lipcon (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <102661332.17274.1328743740506.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1552751360.17224.1328743140040.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5357) Use builder pattern in StoreFile,
 HFile, and HColumnDescriptor instantiation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204108#comment-13204108 ] 

Todd Lipcon commented on HBASE-5357:
------------------------------------

+1!
                
> Use builder pattern in StoreFile, HFile, and HColumnDescriptor instantiation
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-5357
>                 URL: https://issues.apache.org/jira/browse/HBASE-5357
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>
> We have five ways to create an HFile writer, two ways to create a StoreFile writer, and the sets of parameters keep changing, creating a lot of confusion, especially when porting patches across branches. The same thing is happening to HColumnDescriptor. I think we should move to a "builder pattern" solution, e.g.
> {code:java}
>   HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
>       .setParameter1(value1)
>       .setParameter2(value2)
>       ...
>       .instantiate();
> {code}
> Each parameter setter being on the same line will make merges/cherry-pick work properly, we will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember constructors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira