hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5323) Need to handle assertion error while splitting log through ServerShutDownHandler by shutting down the master
Date Fri, 03 Feb 2012 18:17:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199917#comment-13199917
] 

Todd Lipcon commented on HBASE-5323:
------------------------------------

If this is an actual error condition that can be seen in practice (rather than indication
of a failed programmer assumption) it should be changed to an if/throw, not an assert. Most
users don't have asserts enabled in production.
                
> Need to handle assertion error while splitting log through ServerShutDownHandler by shutting
down the master
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5323
>                 URL: https://issues.apache.org/jira/browse/HBASE-5323
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.5
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.94.0, 0.90.7
>
>         Attachments: HBASE-5323.patch
>
>
> We know that while parsing the HLog we expect the proper length from HDFS.
> In WALReaderFSDataInputStream
> {code}
>               assert(realLength >= this.length);
> {code}
> We are trying to come out if the above condition is not satisfied.  But if SSH.splitLog()
gets this problem then it lands in the run method of EventHandler.  This kills the SSH thread
and so further assignment does not happen.  If ROOT and META are to be assigned they cannot
be.
> I think in this condition we abort the master by catching such exceptions.
> Please do suggest.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message