hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5388) Tuning HConnectionManager#getCachedLocation method
Date Sun, 12 Feb 2012 22:34:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206543#comment-13206543
] 

Zhihong Yu commented on HBASE-5388:
-----------------------------------

@Ronghai:
I haven't seen your patch yet.
According to your description in the JIRA, I am guessing something similar to the following:
{code}
@@ -1067,9 +1067,12 @@
         return null;
       }

-      HRegionLocation rl = tableLocations.get(row);
-      if (rl != null) {
-        return rl;
+      Map.Entry<byte[], HRegionLocation> tEntry = tableLocations.lowerEntry(row);
+      if (tEntry != null) {
+        HRegionLocation rl = tEntry.getValue();
+        if (rl != null) {
+          return rl;
+        }
       }
{code}
There is more code in getCachedLocation() following the above lines, revolving around tableLocations.headMap(row)
I wonder how you measured the performance boost - by instrumenting getCachedLocation() I assume
?
                
> Tuning HConnectionManager#getCachedLocation method
> --------------------------------------------------
>
>                 Key: HBASE-5388
>                 URL: https://issues.apache.org/jira/browse/HBASE-5388
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.5
>            Reporter: ronghai.ma
>            Assignee: ronghai.ma
>              Labels: patch
>             Fix For: 0.94.0
>
>
> About 75% improvement in execution time.
> 1. Add the following method in SoftValueSortedMap:
> {code}
> public synchronized <K, V> Entry<K, V> lowerEntry(K key) {
>   return ((TreeMap) this.internalMap).lowerEntry(key);
> }
> {code}
> 2. Modify getCachedLocation:
> {code} 
> Map.Entry<byte[], HRegionLocation> tEntry = tableLocations.lowerEntry(row);
>   if (tEntry != null) {
>   HRegionLocation possibleRegion = tEntry.getValue();
>   //other code
> }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message