hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Bautin (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-5357) Use builder pattern in HColumnDescriptor
Date Wed, 22 Feb 2012 03:24:57 GMT

     [ https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mikhail Bautin updated HBASE-5357:
----------------------------------

    Description: 
We have five ways to create an HFile writer, two ways to create a StoreFile writer, and the
sets of parameters keep changing, creating a lot of confusion, especially when porting patches
across branches. The same thing is happening to HColumnDescriptor. I think we should move
to a "builder pattern" solution, e.g.

{code:java}
  HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
      .setParameter1(value1)
      .setParameter2(value2)
      ...
      .build();
{code}

Each parameter setter being on its own line will make merges/cherry-pick work properly, we
will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember
constructors.

This particular JIRA addresses the HColumnDescriptor refactoring. For StoreFile/HFile refactoring
see HBASE-5442.

  was:
We have five ways to create an HFile writer, two ways to create a StoreFile writer, and the
sets of parameters keep changing, creating a lot of confusion, especially when porting patches
across branches. The same thing is happening to HColumnDescriptor. I think we should move
to a "builder pattern" solution, e.g.

{code:java}
  HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
      .setParameter1(value1)
      .setParameter2(value2)
      ...
      .build();
{code}

Each parameter setter being on its own line will make merges/cherry-pick work properly, we
will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember
constructors.


        Summary: Use builder pattern in HColumnDescriptor  (was: Use builder pattern in StoreFile,
HFile, and HColumnDescriptor instantiation)
    
> Use builder pattern in HColumnDescriptor
> ----------------------------------------
>
>                 Key: HBASE-5357
>                 URL: https://issues.apache.org/jira/browse/HBASE-5357
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D1851.1.patch, Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch
>
>
> We have five ways to create an HFile writer, two ways to create a StoreFile writer, and
the sets of parameters keep changing, creating a lot of confusion, especially when porting
patches across branches. The same thing is happening to HColumnDescriptor. I think we should
move to a "builder pattern" solution, e.g.
> {code:java}
>   HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
>       .setParameter1(value1)
>       .setParameter2(value2)
>       ...
>       .build();
> {code}
> Each parameter setter being on its own line will make merges/cherry-pick work properly,
we will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember
constructors.
> This particular JIRA addresses the HColumnDescriptor refactoring. For StoreFile/HFile
refactoring see HBASE-5442.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message