hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5358) HBaseObjectWritable should be able to serialize generic arrays not defined previously
Date Thu, 09 Feb 2012 22:34:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13204969#comment-13204969
] 

jiraposter@reviews.apache.org commented on HBASE-5358:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3811/#review4995
-----------------------------------------------------------


Looks good.
Please attach patch to JIRA so that Hadoop QA can run test suite.


src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
<https://reviews.apache.org/r/3811/#comment10992>

    code is no longer a byte.
    Please adjust javadoc accordingly.


- Ted


On 2012-02-09 22:18:10, enis wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3811/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-09 22:18:10)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where A extends
Writable. This becomes an issue for example when adding a coprocessor method which takes A[]
(see HBASE-5352).
bq.  
bq.  
bq.  This addresses bug HBASE-5358.
bq.      https://issues.apache.org/jira/browse/HBASE-5358
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 260f982 
bq.    src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java 78513ce 
bq.  
bq.  Diff: https://reviews.apache.org/r/3811/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  enis
bq.  
bq.


                
> HBaseObjectWritable should be able to serialize generic arrays not defined previously
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-5358
>                 URL: https://issues.apache.org/jira/browse/HBASE-5358
>             Project: HBase
>          Issue Type: Improvement
>          Components: coprocessors, io
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>
> HBaseObjectWritable can encode Writable[]'s but, but cannot encode A[] where A extends
Writable. This becomes an issue for example when adding a coprocessor method which takes A[]
(see HBASE-5352). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message