hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5186) Add metrics to ThriftServer
Date Wed, 01 Feb 2012 18:03:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198008#comment-13198008
] 

Phabricator commented on HBASE-5186:
------------------------------------

tedyu has commented on the revision "HBASE-5186 [jira] Add metrics to ThriftServer".

  Thanks for the hard work.
  One last comment :-)

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/thrift/CallQueue.java:131 Good point about clear()
unsuitable for this method.

  Can we use underlyingQueue.iterator() and remove at most maxElements elements from underlyingQueue
?

REVISION DETAIL
  https://reviews.facebook.net/D1461

                
> Add metrics to ThriftServer
> ---------------------------
>
>                 Key: HBASE-5186
>                 URL: https://issues.apache.org/jira/browse/HBASE-5186
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>         Attachments: HBASE-5186.D1461.1.patch, HBASE-5186.D1461.2.patch, HBASE-5186.D1461.3.patch,
HBASE-5186.D1461.4.patch, HBASE-5186.D1461.5.patch, HBASE-5186.D1461.6.patch, HBASE-5186.D1461.7.patch,
HBASE-5186.D1461.8.patch
>
>
> It will be useful to have some metrics (queue length, waiting time, processing time ...)
similar to Hadoop RPC server. This allows us to monitor system health also provide a tool
to diagnose the problem where thrift calls are slow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message