hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5357) Use builder pattern in HColumnDescriptor
Date Fri, 24 Feb 2012 23:01:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216053#comment-13216053
] 

Phabricator commented on HBASE-5357:
------------------------------------

Kannan has commented on the revision "[jira] [HBASE-5357] [89-fb] Refactoring: use the builder
pattern for HColumnDescriptor".

INLINE COMMENTS
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:486 INTEGER.MAX_VALUE seems
to be the block size. Not sure why it was this in the past. But the new behavior, you are
defaulting back to the default (64k).
  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java:544 ditto.

REVISION DETAIL
  https://reviews.facebook.net/D1929

                
> Use builder pattern in HColumnDescriptor
> ----------------------------------------
>
>                 Key: HBASE-5357
>                 URL: https://issues.apache.org/jira/browse/HBASE-5357
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>         Attachments: D1851.1.patch, D1851.2.patch, D1851.3.patch, D1851.4.patch, D1929.1.patch,
D1929.2.patch, Use-builder-pattern-for-HColumnDescriptor-2012-02-21_19_13_35.patch, Use-builder-pattern-for-HColumnDescriptor-2012-02-23_12_42_49.patch,
Use-builder-pattern-for-HColumnDescriptor-20120223113155-e387d251.patch
>
>
> We have five ways to create an HFile writer, two ways to create a StoreFile writer, and
the sets of parameters keep changing, creating a lot of confusion, especially when porting
patches across branches. The same thing is happening to HColumnDescriptor. I think we should
move to a "builder pattern" solution, e.g.
> {code:java}
>   HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
>       .setParameter1(value1)
>       .setParameter2(value2)
>       ...
>       .build();
> {code}
> Each parameter setter being on its own line will make merges/cherry-pick work properly,
we will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember
constructors.
> This particular JIRA addresses the HColumnDescriptor refactoring. For StoreFile/HFile
refactoring see HBASE-5442.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message