hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5443) Add PB-based calls to HRegionInterface
Date Mon, 27 Feb 2012 23:41:51 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217698#comment-13217698
] 

jiraposter@reviews.apache.org commented on HBASE-5443:
------------------------------------------------------



bq.  On 2012-02-27 22:54:55, Gregory Chanan wrote:
bq.  > I notice you followed the same declaration order as HRegionInterface.  Could we
reorder these along say, functionality lines with appropriate comments in the .proto file?
bq.  > NOTE: I see Todd suggested splitting along management/client lines.  That may be
superior.  Here's a sketch of what I think "along functionality lines" would look like:
bq.  > 
bq.  > // Row(s) level
bq.  > get
bq.  > put
bq.  > delete
bq.  > mutate
bq.  > openScanner
bq.  > fetchFromScanner
bq.  > closeScanner
bq.  > lockRow
bq.  > unlockRow
bq.  > 
bq.  > // Region level info
bq.  > getRegionInfo
bq.  > getOnlineRegions
bq.  > getLastFlushTime
bq.  > getStoreFileList
bq.  > 
bq.  > // Region-level mutation
bq.  > flushRegion
bq.  > openRegion
bq.  > closeRegion
bq.  > closeRegionByEncodedName
bq.  > splitRegion
bq.  > compactRegion
bq.  > bulkLoadHFiles
bq.  > execCoprocessor
bq.  > 
bq.  > // RegionServer-level
bq.  > getBlockCacheColumnFamilySummaries
bq.  > replicateLogEntry
bq.  > rollLogWriter
bq.  > stopServer
bq.  >

Good idea.  Will do.


bq.  On 2012-02-27 22:54:55, Gregory Chanan wrote:
bq.  > src/main/proto/HRegionProtocol.proto, line 88
bq.  > <https://reviews.apache.org/r/4054/diff/1/?file=86003#file86003line88>
bq.  >
bq.  >     The name mutate doesn't seem consistent to me.  For one, "mutate" seems to not
support Put/Deletes, but RowMutation *only* seems to support Puts/Deletes.  Perhaps we can
collapse this somehow?

Yes.  I think so.  I used to collapse both put and delete to one call putOrDelete.  But it
sounds not very good to me.  If we collapse them, what do you want it to be called?


bq.  On 2012-02-27 22:54:55, Gregory Chanan wrote:
bq.  > src/main/proto/HRegionProtocol.proto, line 121
bq.  > <https://reviews.apache.org/r/4054/diff/1/?file=86003#file86003line121>
bq.  >
bq.  >     this should be heapSize.

Will fix.


bq.  On 2012-02-27 22:54:55, Gregory Chanan wrote:
bq.  > src/main/proto/HRegionProtocol.proto, line 402
bq.  > <https://reviews.apache.org/r/4054/diff/1/?file=86003#file86003line402>
bq.  >
bq.  >     You got rid of mutateRow and suggest the new put/delete can support as along
as there are no mixed puts and deletes.
bq.  >     
bq.  >     But it looks like mutateRow allowed you to do mixed puts and deletes atomically.
 Could you support atomic puts and deletes with what you have here?

If we collapse put and delete, it should be supported.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review5363
-----------------------------------------------------------


On 2012-02-27 18:54:31, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4054/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-27 18:54:31)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is the first draft of the ProtoBuff HRegionProtocol.  The corresponding java vs
pb method mapping is attached to the jira: https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  Please review.  I'd like to move ahead after we get to some agreement.
bq.  
bq.  
bq.  This addresses bug HBASE-5443.
bq.      https://issues.apache.org/jira/browse/HBASE-5443
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    pom.xml 066c027 
bq.    src/main/proto/HRegionProtocol.proto PRE-CREATION 
bq.    src/main/proto/hbase.proto PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/4054/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Add PB-based calls to HRegionInterface
> --------------------------------------
>
>                 Key: HBASE-5443
>                 URL: https://issues.apache.org/jira/browse/HBASE-5443
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Todd Lipcon
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: region_java-proto-mapping.pdf
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message