hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5283) Request counters may become negative for heavily loaded regions
Date Wed, 01 Feb 2012 06:14:58 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197608#comment-13197608
] 

Hadoop QA commented on HBASE-5283:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12512719/5283.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -140 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.replication.TestReplicationPeer
                  org.apache.hadoop.hbase.io.hfile.TestHFileBlock
                  org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/885//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/885//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/885//console

This message is automatically generated.
                
> Request counters may become negative for heavily loaded regions
> ---------------------------------------------------------------
>
>                 Key: HBASE-5283
>                 URL: https://issues.apache.org/jira/browse/HBASE-5283
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.0
>            Reporter: Zhihong Yu
>            Assignee: Mubarak Seyed
>             Fix For: 0.94.0, 0.92.1
>
>         Attachments: 5283.txt, HBASE-5283.trunk.v1.patch
>
>
> Requests counter showing negative count, example under 'Requests' column: -645470239
> {code}
> Name	Region Server	Start Key	End Key	Requests
> usertable,user2037516127892189021,1326756873774.16833e4566d1daef109b8fdcd1f4b5a6. 	xxx.com:60030
	user2037516127892189021 	user2296868939942738705 	-645470239
> {code}
> RegionLoad.readRequestsCount and RegionLoad.writeRequestsCount are of int type. Our Ops
has been running lots of heavy load operation. RegionLoad.getRequestsCount() overflows int.MAX_VALUE.
It is set to D986E7E1. In table.jsp, RegionLoad.getRequestsCount() is assigned to long type.
D986E7E1 is converted to long FFFFFFFFD986E7E1 which is -645470239 in decimal.
> Suggested fix is to make readRequestsCount and writeRequestsCount long type. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message