hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5304) Pluggable split key policy
Date Wed, 01 Feb 2012 15:07:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197892#comment-13197892
] 

jiraposter@reviews.apache.org commented on HBASE-5304:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3717/#review4744
-----------------------------------------------------------


Looks pretty good.  I'm not strong of the subtleties of the ruby parts -- I'll leave that
to someone else to review.

Could we add a test case for the split veto case? (that is new functionality and a new unexercised
code path).  





http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
<https://reviews.apache.org/r/3717/#comment10477>

    nit



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<https://reviews.apache.org/r/3717/#comment10473>

    maybe debug level log saying splitKeyPolicy loaded?



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/SplitKeyPolicy.java
<https://reviews.apache.org/r/3717/#comment10474>

    sp: sat->say



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ConfigurationUtil.java
<https://reviews.apache.org/r/3717/#comment10476>

    nit



http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ConfigurationUtil.java
<https://reviews.apache.org/r/3717/#comment10478>

    I'm assuming this handles binary encoding (CDATA xml stuff?) and escaping?  What happens
if we insert a goofy string with '<', '>' or other xml control chars?


- jmhsieh


On 2012-02-01 04:52:33, Lars Hofhansl wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3717/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-01 04:52:33)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This patch allows for simple pluggable SplitKeyPolicies. A SplitKeyPolicy determines
the actual to key to be split on after a SplitRequest was issued.
bq.  
bq.  A SplitKeyPolicy can optionally be configured via a Configuration object that is serialized
(as XML) into anb HTableDescriptor (in analogy to the Constraints feature - some common between
the two features is factored out).
bq.  
bq.  DefaultSplitKeyPolicy implements the current logic (which splits along a store's midKey
as determined by HFileReaderV*).
bq.  
bq.  No alternate SplitKeyPolicy is provided as part of this patch.
bq.  
bq.  Some changes to the HBase Shell are included to allow setting arbitrary HTableDescriptor
values.
bq.  
bq.  Jesse Yates and I worked together on the initial version of this patch.
bq.  
bq.  
bq.  This addresses bug HBASE-5304.
bq.      https://issues.apache.org/jira/browse/HBASE-5304
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java
1238830 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/constraint/Constraints.java
1238830 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultSplitKeyPolicy.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
1238830 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/SplitKeyPolicy.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
1238830 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/ConfigurationUtil.java
PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/hbase/trunk/src/main/ruby/hbase/admin.rb 1238830 
bq.  
bq.  Diff: https://reviews.apache.org/r/3717/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Existing tests. No functional changes are introduced with this.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Lars
bq.  
bq.


                
> Pluggable split key policy
> --------------------------
>
>                 Key: HBASE-5304
>                 URL: https://issues.apache.org/jira/browse/HBASE-5304
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.94.0
>
>         Attachments: 5304.txt
>
>
> We need a way to specify custom policies to determine split keys.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message