hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Hsieh (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5327) Print a message when an invalid hbase.rootdir is passed
Date Fri, 10 Feb 2012 04:07:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205210#comment-13205210
] 

Jonathan Hsieh commented on HBASE-5327:
---------------------------------------

Jimmy and I were chatting about the funny control flow and found it strange that {{new Path(invalidRootDir)}}
didn't through IllegalArgumentException, while {{ new Path (new Path(invalidRootDir), ".olddirs")}}
threw an IllegalArguentException.  (I was expecting the mkdirs to IAE, not exists).  

This explains why the slightly odd control flow is necessary and makes me much happier with
v2 patch.

Maybe someone with more HDFS background can chime in about why this seeming inconsistency
exists?



                
> Print a message when an invalid hbase.rootdir is passed
> -------------------------------------------------------
>
>                 Key: HBASE-5327
>                 URL: https://issues.apache.org/jira/browse/HBASE-5327
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.5
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jimmy Xiang
>             Fix For: 0.94.0, 0.90.7, 0.92.1
>
>         Attachments: hbase-5327.txt, hbase-5327_v2.txt
>
>
> As seen on the mailing list: http://comments.gmane.org/gmane.comp.java.hadoop.hbase.user/24124
> If hbase.rootdir doesn't specify a folder on hdfs we crash while opening a path to .oldlogs:
> {noformat}
> 2012-02-02 23:07:26,292 FATAL org.apache.hadoop.hbase.master.HMaster: Unhandled exception.
Starting shutdown.
> java.lang.IllegalArgumentException: java.net.URISyntaxException: Relative path in absolute
URI: hdfs://sv4r11s38:9100.oldlogs
>         at org.apache.hadoop.fs.Path.initialize(Path.java:148)
>         at org.apache.hadoop.fs.Path.<init>(Path.java:71)
>         at org.apache.hadoop.fs.Path.<init>(Path.java:50)
>         at org.apache.hadoop.hbase.master.MasterFileSystem.<init>(MasterFileSystem.java:112)
>         at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaster.java:448)
>         at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:326)
>         at java.lang.Thread.run(Thread.java:662)
> Caused by: java.net.URISyntaxException: Relative path in absolute URI: hdfs://sv4r11s38:9100.oldlogs
>         at java.net.URI.checkPath(URI.java:1787)
>         at java.net.URI.<init>(URI.java:735)
>         at org.apache.hadoop.fs.Path.initialize(Path.java:145)
>         ... 6 more
> {noformat}
> It could also crash anywhere else, this just happens to be the first place we use hbase.rootdir.
We need to verify that it's an actual folder.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message