hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5394) Add ability to include Protobufs in HbaseObjectWritable
Date Tue, 14 Feb 2012 21:58:01 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208059#comment-13208059
] 

jiraposter@reviews.apache.org commented on HBASE-5394:
------------------------------------------------------



bq.  On 2012-02-14 21:52:16, Michael Stack wrote:
bq.  > src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java, line 31
bq.  > <https://reviews.apache.org/r/3898/diff/1/?file=74939#file74939line31>
bq.  >
bq.  >     This is copy/paste from Todd's hadoop patch?  Can the class be package private
even?  Its not used anywhere else it seems.

Sure, will change it to package private.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3898/#review5099
-----------------------------------------------------------


On 2012-02-14 21:53:00, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3898/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-14 21:53:00)
bq.  
bq.  
bq.  Review request for hbase and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Port HADOOP-7379 to HBase so that HBase WritableRpcEngine can support PB-based types,
in addition to Writables.
bq.  This is one of the first steps for wire compatibility.
bq.  
bq.  
bq.  This addresses bug HBASE-5394.
bq.      https://issues.apache.org/jira/browse/HBASE-5394
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java PRE-CREATION 
bq.    src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 3c71192 
bq.    src/main/java/org/apache/hadoop/hbase/util/ProtoUtil.java PRE-CREATION 
bq.    src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3898/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  The TestPBOnWritableRpc unit test tests using PB-based type and Writable with WritableRpcEngine.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Add ability to include Protobufs in HbaseObjectWritable
> -------------------------------------------------------
>
>                 Key: HBASE-5394
>                 URL: https://issues.apache.org/jira/browse/HBASE-5394
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Zhihong Yu
>            Assignee: Jimmy Xiang
>
> This is a port of HADOOP-7379
> This is to add the cases to HbaseObjectWritable to handle subclasses of Message, the
superclass of codegenned protobufs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message