hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Meil (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-5330) TestCompactSelection - adding 2 test cases to testCompactionRatio
Date Fri, 03 Feb 2012 18:57:53 GMT
TestCompactSelection - adding 2 test cases to testCompactionRatio
-----------------------------------------------------------------

                 Key: HBASE-5330
                 URL: https://issues.apache.org/jira/browse/HBASE-5330
             Project: HBase
          Issue Type: Improvement
            Reporter: Doug Meil
            Assignee: Doug Meil
            Priority: Minor


There were three existing assertions in the compaction test that did "max # of files" assertions...
{code}
    assertEquals(maxFiles,
        store.compactSelection(sfCreate(7,6,5,4,3,2,1)).getFilesToCompact().size());
{code}

... and for references ...

{code}
  assertEquals(maxFiles,
        store.compactSelection(sfCreate(true, 7,6,5,4,3,2,1)).getFilesToCompact().size());
{code}
 
... but they didn't assert against which StoreFiles got selected.  While the number of StoreFiles
is the same, the files selected are actually different, and I thought that there should be
explicit assertions showing that.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message