hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5310) HConnectionManager cache server name enhancement
Date Wed, 01 Feb 2012 01:44:56 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13197490#comment-13197490
] 

Hadoop QA commented on HBASE-5310:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12512705/hbase-5310.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -140 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestHFileBlock

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/884//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/884//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/884//console

This message is automatically generated.
                
> HConnectionManager cache server name enhancement
> ------------------------------------------------
>
>                 Key: HBASE-5310
>                 URL: https://issues.apache.org/jira/browse/HBASE-5310
>             Project: HBase
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: hbase-5310.txt
>
>
> HConnectionManager uses deprecated HServerAddress to create server cache key which needs
to resolve the address every time.
> It should be better to use HRegionLocation.getHostnamePort() instead.
> In our cluster we have some DNS issue, resolving an address fails sometime which kills
the application since it is a runtime
> exception IllegalArgumentException thrown at HServerAddress.getResolvedAddress.  This
change will fix this issue as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message