hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5394) Add ability to include Protobufs in HbaseObjectWritable
Date Tue, 14 Feb 2012 21:54:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208052#comment-13208052

jiraposter@reviews.apache.org commented on HBASE-5394:

This is an automatically generated e-mail. To reply, visit:

(Updated 2012-02-14 21:53:00.016924)

Review request for hbase and Todd Lipcon.


Addressed Todd's comment.


Port HADOOP-7379 to HBase so that HBase WritableRpcEngine can support PB-based types, in addition
to Writables.
This is one of the first steps for wire compatibility.

This addresses bug HBASE-5394.

Diffs (updated)

  src/main/java/org/apache/hadoop/hbase/io/DataOutputOutputStream.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java 3c71192 
  src/main/java/org/apache/hadoop/hbase/util/ProtoUtil.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java PRE-CREATION 

Diff: https://reviews.apache.org/r/3898/diff


The TestPBOnWritableRpc unit test tests using PB-based type and Writable with WritableRpcEngine.



> Add ability to include Protobufs in HbaseObjectWritable
> -------------------------------------------------------
>                 Key: HBASE-5394
>                 URL: https://issues.apache.org/jira/browse/HBASE-5394
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Zhihong Yu
>            Assignee: Jimmy Xiang
> This is a port of HADOOP-7379
> This is to add the cases to HbaseObjectWritable to handle subclasses of Message, the
superclass of codegenned protobufs.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message