hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Bautin (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HBASE-5442) Use builder pattern in StoreFile and HFile
Date Wed, 22 Feb 2012 03:24:57 GMT
Use builder pattern in StoreFile and HFile
------------------------------------------

                 Key: HBASE-5442
                 URL: https://issues.apache.org/jira/browse/HBASE-5442
             Project: HBase
          Issue Type: Improvement
            Reporter: Mikhail Bautin
            Assignee: Mikhail Bautin


We have five ways to create an HFile writer, two ways to create a StoreFile writer, and the
sets of parameters keep changing, creating a lot of confusion, especially when porting patches
across branches. The same thing is happening to HColumnDescriptor. I think we should move
to a "builder pattern" solution, e.g.

{code:java}
  HFileWriter w = HFile.getWriterBuilder(conf, <some common args>)
      .setParameter1(value1)
      .setParameter2(value2)
      ...
      .build();
{code}

Each parameter setter being on its own line will make merges/cherry-pick work properly, we
will not have to even mention default parameters again, and we can eliminate a dozen impossible-to-remember
constructors.

This particular JIRA addresses StoreFile and HFile refactoring. For HColumnDescriptor refactoring
see HBASE-5357.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message