Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AB2B29C3C for ; Sun, 1 Jan 2012 02:53:59 +0000 (UTC) Received: (qmail 57840 invoked by uid 500); 1 Jan 2012 02:53:59 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 57675 invoked by uid 500); 1 Jan 2012 02:53:54 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57667 invoked by uid 99); 1 Jan 2012 02:53:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Jan 2012 02:53:52 +0000 X-ASF-Spam-Status: No, hits=-2001.3 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Jan 2012 02:53:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C99781270E9 for ; Sun, 1 Jan 2012 02:53:30 +0000 (UTC) Date: Sun, 1 Jan 2012 02:53:30 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <735051208.56348.1325386410827.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1482122821.45004.1324881870945.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5094) The META can hold an entry for a region with a different server name from the one actually in the AssignmentManager thus making the region inaccessible. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178101#comment-13178101 ] Hudson commented on HBASE-5094: ------------------------------- Integrated in HBase-TRUNK #2600 (See [https://builds.apache.org/job/HBase-TRUNK/2600/]) HBASE-5094 The META can hold an entry for a region with a different server name from the one actually in the AssignmentManager thus making the region inaccessible. (Ram) ramkrishna : Files : * /hbase/trunk/CHANGES.txt * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > The META can hold an entry for a region with a different server name from the one actually in the AssignmentManager thus making the region inaccessible. > -------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-5094 > URL: https://issues.apache.org/jira/browse/HBASE-5094 > Project: HBase > Issue Type: Bug > Affects Versions: 0.92.0 > Reporter: ramkrishna.s.vasudevan > Priority: Critical > Attachments: HBASE-5094_1.patch > > > {code} > RegionState rit = this.services.getAssignmentManager().isRegionInTransition(e.getKey()); > ServerName addressFromAM = this.services.getAssignmentManager() > .getRegionServerOfRegion(e.getKey()); > if (rit != null && !rit.isClosing() && !rit.isPendingClose()) { > // Skip regions that were in transition unless CLOSING or > // PENDING_CLOSE > LOG.info("Skip assigning region " + rit.toString()); > } else if (addressFromAM != null > && !addressFromAM.equals(this.serverName)) { > LOG.debug("Skip assigning region " > + e.getKey().getRegionNameAsString() > + " because it has been opened in " > + addressFromAM.getServerName()); > } > {code} > In ServerShutDownHandler we try to get the address in the AM. This address is initially null because it is not yet updated after the region was opened .i.e. the CAll back after node deletion is not yet done in the master side. > But removal from RIT is completed on the master side. So this will trigger a new assignment. > So there is a small window between the online region is actually added in to the online list and the ServerShutdownHandler where we check the existing address in AM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira