Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 26 Jan 2012 23:25:46 +0000 (UTC)
From: "Phabricator (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <371044835.83227.1327620346116.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1097688746.74579.1327447120281.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5274) Filter out the expired store file
 scanner during the compaction
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194268#comment-13194268 ] 

Phabricator commented on HBASE-5274:
------------------------------------

mbautin has commented on the revision "[jira] [HBASE-5274] Filter out expired scanners on compaction as well".

  Lars: please see my response inline.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:975 In that case I would have to make LruBlockCache.getCachedFileNamesForTest public. In addition, this patch makes HBASE-5010 implementation consistent in 89-fb and trunk, and moving the unit test around might create confusion.

  Please let me know if this is OK to commit.

REVISION DETAIL
  https://reviews.facebook.net/D1473

                
> Filter out the expired store file scanner during the compaction
> ---------------------------------------------------------------
>
>                 Key: HBASE-5274
>                 URL: https://issues.apache.org/jira/browse/HBASE-5274
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D1407.1.patch, D1407.1.patch, D1407.1.patch, D1407.1.patch, D1407.1.patch, D1473.1.patch
>
>
> During the compaction time, HBase will generate a store scanner which will scan a list of store files. And it would be more efficient to filer out the expired store file since there is no need to read any key values from these store files.
> This optimization has been already implemented on 89-fb and this is the building block for HBASE-5199 as well. It is supposed to be no-ops to compact the expired store files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira