Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0A99FB718 for ; Wed, 4 Jan 2012 19:46:25 +0000 (UTC) Received: (qmail 80196 invoked by uid 500); 4 Jan 2012 19:46:24 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 80014 invoked by uid 500); 4 Jan 2012 19:46:24 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80003 invoked by uid 99); 4 Jan 2012 19:46:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2012 19:46:24 +0000 X-ASF-Spam-Status: No, hits=-2001.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2012 19:46:23 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 857A5138994 for ; Wed, 4 Jan 2012 19:45:39 +0000 (UTC) Date: Wed, 4 Jan 2012 19:45:39 +0000 (UTC) From: "stack (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <313897801.6197.1325706339548.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <7438069.53536.1325229690660.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5109) Fix TestAvroServer so that it waits properly for the modifyTable operation to complete MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179805#comment-13179805 ] stack commented on HBASE-5109: ------------------------------ +1 on committing the patch. Its some nice, if small, cleanup. > Fix TestAvroServer so that it waits properly for the modifyTable operation to complete > -------------------------------------------------------------------------------------- > > Key: HBASE-5109 > URL: https://issues.apache.org/jira/browse/HBASE-5109 > Project: HBase > Issue Type: Bug > Components: test > Reporter: Ming Ma > Assignee: Ming Ma > Attachments: HBASE-5109-0.92.patch > > > TestAvroServer has the following issue > > impl.modifyTable(tableAname, tableA); > // It can take a while for the change to take effect. Wait here a while. > while(impl.describeTable(tableAname) == null ) { > Threads.sleep(100); > } > assertTrue(impl.describeTable(tableAname).maxFileSize == 123456L); > > impl.describeTable(tableAname) returns the default maxSize 256M right away as modifyTable is async. Before HBASE-4328 is fixed, we can fix the test code to wait for say max of 5 seconds to check if impl.describeTable(tableAname).maxFileSize is uploaded to 123456L. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira