Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E52FD9B98 for ; Sat, 7 Jan 2012 22:43:06 +0000 (UTC) Received: (qmail 98356 invoked by uid 500); 7 Jan 2012 22:43:06 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 98312 invoked by uid 500); 7 Jan 2012 22:43:06 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 98304 invoked by uid 99); 7 Jan 2012 22:43:06 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jan 2012 22:43:06 +0000 X-ASF-Spam-Status: No, hits=-2001.6 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Jan 2012 22:43:04 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 2C62D13D5F0 for ; Sat, 7 Jan 2012 22:42:43 +0000 (UTC) Date: Sat, 7 Jan 2012 22:42:43 +0000 (UTC) From: "stack (Updated) (JIRA)" To: issues@hbase.apache.org Message-ID: <1667015741.19283.1325976163196.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1758784668.13691.1325831979880.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HBASE-5134) Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-5134: ------------------------- Attachment: 5134-v3.txt v3 is same as v2 except for one line change in TestAssignmentManager where I chance the generic params on a mocked method to be specific (The commit of Mings' new closeRegion method broke this). All good now. > Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface > ---------------------------------------------------------------------------------------------- > > Key: HBASE-5134 > URL: https://issues.apache.org/jira/browse/HBASE-5134 > Project: HBase > Issue Type: Improvement > Reporter: stack > Assignee: stack > Fix For: 0.94.0 > > Attachments: 5134-v2.txt, 5134-v3.txt > > > Its broke having these meta methods in HConnection. They take ServerCallables which themselves have HConnections inevitably. It makes for a tangle in the model and frustrates being able to do mocked implemenations of HConnection. These methods better belong in something like HConnectionManager, or elsewhere altogether. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira