hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5295) Improve the Thrift API to switch on/off writing to wal for Mutations
Date Sun, 29 Jan 2012 15:27:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195767#comment-13195767
] 

Phabricator commented on HBASE-5295:
------------------------------------

tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch
on/off writing to wal for Mutations".

  thrift2/TDelete doesn't support WAL switch.
  Delete is a mutation:
  public class Delete extends Mutation

  thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and
incrementFromThrift(). deleteFromThrift() should also have this call.

  w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:

  https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845

  There're so many Thrift experts at FB, I am sure they have better idea about the two packages.

REVISION DETAIL
  https://reviews.facebook.net/D1515

                
> Improve the Thrift API  to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5295
>                 URL: https://issues.apache.org/jira/browse/HBASE-5295
>             Project: HBase
>          Issue Type: Improvement
>          Components: thrift
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes.
Support it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message