hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
Date Sun, 22 Jan 2012 21:22:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190788#comment-13190788
] 

stack commented on HBASE-5237:
------------------------------

+1 on commit to 0.92 branch so we are consistent with 0.90 and with TRUNK.

The patch is a little odd though in that if getRegionPlan returns null, it means no servers
online supposedly.  And then in this case we set a flag up in TM.  But TM only runs every
30minutes so the setting of this flag doesn't do much?  This patch is setting all servers
offline in the middle of an assign.  It doesn't seem like we should be doing this here.

Anyways, +1 so we are consistent with other branches.
                
> Addendum for HBASE-5160 and HBASE-4397
> --------------------------------------
>
>                 Key: HBASE-5237
>                 URL: https://issues.apache.org/jira/browse/HBASE-5237
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.5
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.92.0, 0.90.6
>
>         Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
>       if (plan == null) {
>         debugLog(state.getRegion(),
>             "Unable to determine a plan to assign " + state);
>         return; // Should get reassigned later when RIT times out.
>       }
> {code}
> I think in this scenario also 
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message