hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy Xiang (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5136) Redundant MonitoredTask instances in case of distributed log splitting retry
Date Fri, 13 Jan 2012 17:34:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185688#comment-13185688
] 

Jimmy Xiang commented on HBASE-5136:
------------------------------------

Instead of reuse the same status object, can we abort the original one?

{code}
    waitForSplittingCompletion(batch, status);
    if (batch.done != batch.installed) {
      batch.isDead = true;
      tot_mgr_log_split_batch_err.incrementAndGet();
      LOG.warn("error while splitting logs in " + logDirs +
      " installed = " + batch.installed + " but only " + batch.done + " done");
=> update the status message and abort it here
      throw new IOException("error or interrupt while splitting logs in "
          + logDirs + " Task = " + batch);
    }
{code}
                
> Redundant MonitoredTask instances in case of distributed log splitting retry
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-5136
>                 URL: https://issues.apache.org/jira/browse/HBASE-5136
>             Project: HBase
>          Issue Type: Task
>            Reporter: Zhihong Yu
>            Assignee: Zhihong Yu
>         Attachments: 5136.txt
>
>
> In case of log splitting retry, the following code would be executed multiple times:
> {code}
>   public long splitLogDistributed(final List<Path> logDirs) throws IOException
{
>     MonitoredTask status = TaskMonitor.get().createStatus(
>           "Doing distributed log split in " + logDirs);
> {code}
> leading to multiple MonitoredTask instances.
> User may get confused by multiple distributed log splitting entries for the same region
server on master UI

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message