hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
Date Sat, 21 Jan 2012 17:45:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190479#comment-13190479
] 

Hadoop QA commented on HBASE-5237:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511291/HBASE-5237_trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -145 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/826//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/826//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/826//console

This message is automatically generated.
                
> Addendum for HBASE-5160 and HBASE-4397
> --------------------------------------
>
>                 Key: HBASE-5237
>                 URL: https://issues.apache.org/jira/browse/HBASE-5237
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.5
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.92.0, 0.90.6
>
>         Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
>       if (plan == null) {
>         debugLog(state.getRegion(),
>             "Unable to determine a plan to assign " + state);
>         return; // Should get reassigned later when RIT times out.
>       }
> {code}
> I think in this scenario also 
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message