hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5199) Delete out of TTL store files before compaction selection
Date Tue, 24 Jan 2012 18:42:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192352#comment-13192352
] 

Phabricator commented on HBASE-5199:
------------------------------------

Liyin has requested a review of the revision "[jira][HBASE-5199] Delete out of TTL store files
before compaction selection ".

  Hi @Karthik,
  The new diff have changed the logic a little bit. There is no need to get the write lock
to do the deletion job for these expired store files. It would be much easier to put these
expired store files directly to the compaction, which will do the deletion job for free.

  Would you mind reviewing it again? Thanks

REVISION DETAIL
  https://reviews.facebook.net/D1311

                
> Delete out of TTL store files before compaction selection
> ---------------------------------------------------------
>
>                 Key: HBASE-5199
>                 URL: https://issues.apache.org/jira/browse/HBASE-5199
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Liyin Tang
>            Assignee: Liyin Tang
>         Attachments: D1311.1.patch, D1311.2.patch, D1311.3.patch, D1311.4.patch
>
>
> Currently, HBase deletes the out of TTL store files after compaction. We can change the
sequence to delete the out of TTL store files before selecting store files for compactions.

> In this way, HBase can keep deleting the old invalid store files without compaction,
and also prevent from unnecessary compactions since the out of TTL store files will be deleted
before the compaction selection.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message