hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5150) Fail in a thread may not fail a test, clean up log splitting test
Date Mon, 09 Jan 2012 02:39:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182351#comment-13182351
] 

jiraposter@reviews.apache.org commented on HBASE-5150:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3433/
-----------------------------------------------------------

(Updated 2012-01-09 02:39:28.394063)


Review request for hbase, Todd Lipcon and Michael Stack.


Changes
-------

Updated per comments.


Summary
-------

Cleaned up the tests introduced in HBASE-5081, added some documentation.


This addresses bug HBASE-5150.
    https://issues.apache.org/jira/browse/HBASE-5150


Diffs (updated)
-----

  src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java 0ef0e33 
  src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java b0487f1 
  src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java 0974b56 

Diff: https://reviews.apache.org/r/3433/diff


Testing
-------

Affected tests: TestDistributedLogSplitting and TestSplitLogManager, are passed


Thanks,

Jimmy


                
> Fail in a thread may not fail a test, clean up log splitting test
> -----------------------------------------------------------------
>
>                 Key: HBASE-5150
>                 URL: https://issues.apache.org/jira/browse/HBASE-5150
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: hbase-5150.txt
>
>
> This is to clean up some tests for HBASE-5081.  The Assert.fail method in a separate
thread will terminate the thread, but may not fail the test.
> We can use callable, so that we can get the error in getting the result. 
> Some documentation to explain the test will be helpful too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message