hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Yu (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
Date Sat, 21 Jan 2012 02:54:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190281#comment-13190281
] 

Zhihong Yu commented on HBASE-4913:
-----------------------------------

@Mubarak:
The patch is of decent size.
Publishing on review board would allow people to give better review.

Still need to look at your code in more detail.
{code}
+  private void compactCFTable(int op) throws Exception {
{code}
Would multiFamilyTableCompaction() be a better name ?
{code}
+      if (op == 1) {
+        performMultiplePutAndFlush(admin, hTable, row, FAMILY, 3, 2);
+      } else {
+        performMultiplePutAndFlush(admin, hTable, row, FAMILY, 3, 2);
+      }
{code}
I don't seem to find the difference between the two statements.
{code}
+   * @param regionName region to compact
+   * @param columnFamily column family within the region to compact
+   * @throws IOException if a remote or network exception occurs
+   */
+  public void compact(String tableOrRegionName, String columnFamily)
{code}
The javadoc is out of sync with method signature.
                
> Per-CF compaction Via the Shell
> -------------------------------
>
>                 Key: HBASE-4913
>                 URL: https://issues.apache.org/jira/browse/HBASE-4913
>             Project: HBase
>          Issue Type: Sub-task
>          Components: client, regionserver
>            Reporter: Nicolas Spiegelberg
>            Assignee: Mubarak Seyed
>             Fix For: 0.94.0
>
>         Attachments: HBASE-4913.trunk.v1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message