hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5243) LogSyncerThread not getting shutdown waiting for the interrupted flag
Date Mon, 23 Jan 2012 21:43:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191494#comment-13191494
] 

Hadoop QA commented on HBASE-5243:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511556/5243-92.addendum
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause mvn compile goal to fail.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/842//testReport/
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/842//console

This message is automatically generated.
                
> LogSyncerThread not getting shutdown waiting for the interrupted flag
> ---------------------------------------------------------------------
>
>                 Key: HBASE-5243
>                 URL: https://issues.apache.org/jira/browse/HBASE-5243
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.5
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.90.6, 0.92.1
>
>         Attachments: 5243-92.addendum, HBASE-5243_0.90.patch, HBASE-5243_0.90_1.patch,
HBASE-5243_trunk.patch
>
>
> In the LogSyncer run() we keep looping till this.isInterrupted flag is set.
> But in some cases the DFSclient is consuming the Interrupted exception.  So
> we are running into infinite loop in some shutdown cases.
> I would suggest that as we are the ones who tries to close down the
> LogSyncerThread we can introduce a variable like
> Close or shutdown and based on the state of this flag along with
> isInterrupted() we can make the thread stop.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message