hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5134) Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection Interface
Date Mon, 09 Jan 2012 22:37:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182880#comment-13182880

Hadoop QA commented on HBASE-5134:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 18 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/709//console

This message is automatically generated.
> Remove getRegionServerWithoutRetries and getRegionServerWithRetries from HConnection
> ----------------------------------------------------------------------------------------------
>                 Key: HBASE-5134
>                 URL: https://issues.apache.org/jira/browse/HBASE-5134
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.94.0
>         Attachments: 5134-v2.txt, 5134-v3.txt, 5134-v4.txt, 5134-v5.txt
> Its broke having these meta methods in HConnection.  They take ServerCallables which
themselves have HConnections inevitably.   It makes for a tangle in the model and frustrates
being able to do mocked implemenations of HConnection.  These methods better belong in something
like HConnectionManager, or elsewhere altogether.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message