hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5150) Fail in a thread may not fail a test, clean up log splitting test
Date Mon, 09 Jan 2012 03:49:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182359#comment-13182359
] 

jiraposter@reviews.apache.org commented on HBASE-5150:
------------------------------------------------------



bq.  On 2012-01-09 03:01:16, Prakash Khemani wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java, line
316
bq.  > <https://reviews.apache.org/r/3433/diff/2/?file=67170#file67170line316>
bq.  >
bq.  >     There is no reason to wait for 3 seconds over here

If everything works as expected, we won't have to wait here, since those two fail() calls
won't be called.  I'd like to give it some time to make sure the second splitLogDistributed()
is really blocked there.


bq.  On 2012-01-09 03:01:16, Prakash Khemani wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java, line
326
bq.  > <https://reviews.apache.org/r/3433/diff/2/?file=67170#file67170line326>
bq.  >
bq.  >     Since fs is from master.getMasterFileSystem().getFileSystem(), I am pretty sure
it gets cleaned up at the end of the test when the cluster is stopped. Did you see the files
hanging around?

ShutdownMiniCluster will try to clean up the test dir.  Just want to be safe.


bq.  On 2012-01-09 03:01:16, Prakash Khemani wrote:
bq.  > src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java, line 481
bq.  > <https://reviews.apache.org/r/3433/diff/2/?file=67171#file67171line481>
bq.  >
bq.  >     The test should fail if there is an exception.

That fail() doesn't fail the test.   If there is an exception, those waitForCounter() will
actually fail the test.


- Jimmy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3433/#review4259
-----------------------------------------------------------


On 2012-01-09 02:39:28, Jimmy Xiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3433/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-09 02:39:28)
bq.  
bq.  
bq.  Review request for hbase, Todd Lipcon and Michael Stack.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Cleaned up the tests introduced in HBASE-5081, added some documentation.
bq.  
bq.  
bq.  This addresses bug HBASE-5150.
bq.      https://issues.apache.org/jira/browse/HBASE-5150
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java 0ef0e33 
bq.    src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java b0487f1

bq.    src/test/java/org/apache/hadoop/hbase/master/TestSplitLogManager.java 0974b56 
bq.  
bq.  Diff: https://reviews.apache.org/r/3433/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Affected tests: TestDistributedLogSplitting and TestSplitLogManager, are passed
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jimmy
bq.  
bq.


                
> Fail in a thread may not fail a test, clean up log splitting test
> -----------------------------------------------------------------
>
>                 Key: HBASE-5150
>                 URL: https://issues.apache.org/jira/browse/HBASE-5150
>             Project: HBase
>          Issue Type: Test
>    Affects Versions: 0.94.0
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>            Priority: Minor
>         Attachments: hbase-5150.txt
>
>
> This is to clean up some tests for HBASE-5081.  The Assert.fail method in a separate
thread will terminate the thread, but may not fail the test.
> We can use callable, so that we can get the error in getting the result. 
> Some documentation to explain the test will be helpful too.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message