hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5176) AssignmentManager: getRegion: logging nit adds a redundant '+'
Date Wed, 11 Jan 2012 02:16:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183797#comment-13183797
] 

Hadoop QA commented on HBASE-5176:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12510142/HBASE-5176.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -147 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 78 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/725//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/725//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/725//console

This message is automatically generated.
                
> AssignmentManager: getRegion: logging nit  adds a redundant '+'  
> -----------------------------------------------------------------
>
>                 Key: HBASE-5176
>                 URL: https://issues.apache.org/jira/browse/HBASE-5176
>             Project: HBase
>          Issue Type: Bug
>         Environment: hadoop 1.0.0 , zk 3.4.2 , hbase 0.92.0 rc3
>            Reporter: Karthik K
>             Fix For: 0.92.0
>
>         Attachments: HBASE-5176.patch
>
>
> From the logs of HMaster: 
> 2012-01-10 17:28:24,370 DEBUG org.apache.hadoop.hbase.master.AssignmentManager: Found
an existing plan for -ROOT-,,0.70236052 destination server is + localhost,60020,1326242475275
> Was the '+' intended to be there , as part of some token for log verification or just
being redundant , w.r.t the following string append ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message