hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5230) Unit test to ensure compactions don't cache data on write
Date Sat, 21 Jan 2012 03:08:46 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190291#comment-13190291
] 

Phabricator commented on HBASE-5230:
------------------------------------

tedyu has commented on the revision "[jira] [HBASE-5230] Extend TestCacheOnWrite to ensure
we don't cache data blocks on compaction".

  Good job.

  Some minor comments.

  Please submit to Hadoop QA for test suite run.

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:746 Can this method be
made package private ?
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:756 Please add javadoc for
parameter isCompaction
  src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java:880 Can we
add the following line at the beginning of this method ?
  if (!LOG.isDebugEnabled()) return;
  src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java:253 Would testCacheOnWriteOffDuringCompaction
be a better name ?

  Alternatively javadoc can be added for this method to explain what it does.
  src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java:295 Nice.

REVISION DETAIL
  https://reviews.facebook.net/D1353

                
> Unit test to ensure compactions don't cache data on write
> ---------------------------------------------------------
>
>                 Key: HBASE-5230
>                 URL: https://issues.apache.org/jira/browse/HBASE-5230
>             Project: HBase
>          Issue Type: Test
>            Reporter: Mikhail Bautin
>            Assignee: Mikhail Bautin
>            Priority: Minor
>         Attachments: D1353.1.patch
>
>
> Create a unit test for HBASE-3976 (making sure we don't cache data blocks on write during
compactions even if cache-on-write is enabled generally enabled). This is because we have
very different implementations of HBASE-3976 without HBASE-4422 CacheConfig (on top of 89-fb,
created by Liyin) and with CacheConfig (presumably it's there but not sure if it even works,
since the patch in HBASE-3976 may not have been committed). We need to create a unit test
to verify that we don't cache data blocks on write during compactions, and resolve HBASE-3976
so that this new unit test does not fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message