hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phabricator (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5297) Update metrics numOpenConnections and callQueueLen directly in HBaseServer
Date Sat, 28 Jan 2012 04:57:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195419#comment-13195419
] 

Phabricator commented on HBASE-5297:
------------------------------------

tedyu has commented on the revision "HBASE-5297 [jira] Update metrics numOpenConnections and
callQueueLen directly in HBaseServer".

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java:1275 A short javadoc would be
helpful for this method.
  I think adding a BlockingQueue<Call> parameter for the actual call queue being updated
would make this method simpler - only one set() call is needed.
  src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java:1277 This should be priorityCallQueue,
right ?

REVISION DETAIL
  https://reviews.facebook.net/D1509

                
> Update metrics numOpenConnections and callQueueLen directly in HBaseServer
> --------------------------------------------------------------------------
>
>                 Key: HBASE-5297
>                 URL: https://issues.apache.org/jira/browse/HBASE-5297
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Scott Chen
>            Assignee: Scott Chen
>            Priority: Minor
>             Fix For: 0.94.0
>
>         Attachments: HBASE-5297.D1509.1.patch, HBASE-5297.D1509.2.patch
>
>
> It's better to directly update the metrics outside HBaseRpcMetrics so that HBaseRpcMetrics
doesn't have to hold reference to HBaseServer.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message