hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5205) Delete handles deleteFamily incorrectly
Date Mon, 16 Jan 2012 04:57:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186691#comment-13186691
] 

Hadoop QA commented on HBASE-5205:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12510658/5205.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 javadoc.  The javadoc tool appears to have generated -145 warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.mapreduce.TestImportTsv
                  org.apache.hadoop.hbase.mapred.TestTableMapReduce
                  org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/769//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/769//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/769//console

This message is automatically generated.
                
> Delete handles deleteFamily incorrectly
> ---------------------------------------
>
>                 Key: HBASE-5205
>                 URL: https://issues.apache.org/jira/browse/HBASE-5205
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Lars Hofhansl
>            Priority: Minor
>         Attachments: 5205.txt
>
>
> Delete.deleteFamily clears all other markers for the same family.
> That is not correct as some of these other markers might be for a later time.
> That logic should be removed.
> If (really) needed this can be slightly optimized by keeping track of the max TS so far
for each family.
> If both the TS-so-far and the TS of a new deleteFamily request is < LATEST_TIMESTAMP
and the TS-so-far is < deleteFamily marker, or if both the TS-so-far and the new TS equal
LATEST_TIMESTAMP, then the previous delete markerz for that family could be removed.
> I think that might be overkill, as most deletes issued from clients are for LATEST_TIMESTAMP
(which the server translates to the current time).
> I'll have a (one-line) patch soon. Unless folks insist on the optimization I mentioned
above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message