hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3949) Add "Master" link to RegionServer pages
Date Thu, 05 Jan 2012 01:28:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13180083#comment-13180083

jiraposter@reviews.apache.org commented on HBASE-3949:

This is an automatically generated e-mail. To reply, visit:

(Updated 2012-01-05 01:28:49.385063)

Review request for hbase, Todd Lipcon and Michael Stack.


Have servlet read Configuration rather than passing it as a context attribute


This patch addresses HBASE-3949: Add "Master" link to RegionServer pages

I used the first suggestion in the patch, "use the RS local config setting"

This addresses bug HBASE-3949.

Diffs (updated)

  src/main/jamon/org/apache/hbase/tmpl/regionserver/RSStatusTmpl.jamon 24caabd 
  src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 6ac23d6 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 64e61bb 

Diff: https://reviews.apache.org/r/3398/diff


- Ran unit test TestRSStatusServlet.java {Passed}

- Ran a few simple configurations:
    - No hbase.master.info.port specified (default) {Link worked}
    - hbase.master.info.port specified and > 0 {Link worked}
    - hbase.master.info.port specified and < 0 {Printed proper message}



> Add "Master" link to RegionServer pages
> ---------------------------------------
>                 Key: HBASE-3949
>                 URL: https://issues.apache.org/jira/browse/HBASE-3949
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>    Affects Versions: 0.90.3, 0.92.0
>            Reporter: Lars George
>            Assignee: Gregory Chanan
>            Priority: Minor
>              Labels: noob
> Use the ZK info where the master is to add a UI link on the top of each RegionServer
page. Currently you cannot navigate directly to the Master UI once you are on a RS page.
> Not sure if the info port is exposed OTTOMH, but we could either use the RS local config
setting for that or add it to ZK to enable lookup.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message