Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 5 Dec 2011 08:05:40 +0000 (UTC)
From: "Hudson (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <83982119.40468.1323072340130.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2103263862.37808.1322947239925.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4942) HMaster is unable to start of HFile
 V1 is used
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HBASE-4942?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1316=
2657#comment-13162657 ]=20

Hudson commented on HBASE-4942:
-------------------------------

Integrated in HBase-TRUNK-security #22 (See [https://builds.apache.org/job/=
HBase-TRUNK-security/22/])
    HBASE-4942  HMaster is unable to start of HFile V1 is used (Honghua Zhu=
)

tedyu :=20
Files :=20
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV1=
.java

               =20
> HMaster is unable to start of HFile V1 is used
> ----------------------------------------------
>
>                 Key: HBASE-4942
>                 URL: https://issues.apache.org/jira/browse/HBASE-4942
>             Project: HBase
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 0.92.0
>            Reporter: Ted Yu
>            Assignee: honghua zhu
>             Fix For: 0.92.0, 0.94.0
>
>         Attachments: HBase_0.92.0_HBASE-4942, HBase_0.94.0_HBASE-4942
>
>
> This was reported by HH Zhu (zhh200910@gmail.com)
> If the following is specified in hbase-site.xml=EF=BC=9A
> {code}
>     <property>
>         <name>hfile.format.version</name>
>         <value>1</value>
>     </property>
> {code}
> Clear the hdfs directory "hbase.rootdir" so that MasterFileSystem.bootstr=
ap() is executed.
> You would see:
> {code}
> java.lang.NullPointerException
>     at org.apache.hadoop.hbase.io.hfile.HFileReaderV1.close(HFileReaderV1=
.java:358)
>     at org.apache.hadoop.hbase.regionserver.StoreFile$Reader.close(StoreF=
ile.java:1083)
>     at org.apache.hadoop.hbase.regionserver.StoreFile.closeReader(StoreFi=
le.java:570)
>     at org.apache.hadoop.hbase.regionserver.Store.close(Store.java:441)
>     at org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:=
782)
>     at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:71=
7)
>     at org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:68=
8)
>     at org.apache.hadoop.hbase.master.MasterFileSystem.bootstrap(MasterFi=
leSystem.java:390)
>     at org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(Maste=
rFileSystem.java:356)
>     at org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileS=
ystemLayout(MasterFileSystem.java:128)
>     at org.apache.hadoop.hbase.master.MasterFileSystem.<init>(MasterFileS=
ystem.java:113)
>     at org.apache.hadoop.hbase.master.HMaster.finishInitialization(HMaste=
r.java:435)
>     at org.apache.hadoop.hbase.master.HMaster.run(HMaster.java:314)
>     at java.lang.Thread.run(Thread.java:619)
> {code}
> The above exception would lead to:
> {code}
> java.lang.RuntimeException: HMaster Aborted
>     at org.apache.hadoop.hbase.master.HMasterCommandLine.startMaster(HMas=
terCommandLine.java:152)
>     at org.apache.hadoop.hbase.master.HMasterCommandLine.run(HMasterComma=
ndLine.java:103)
>     at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:65)
>     at org.apache.hadoop.hbase.util.ServerCommandLine.doMain(ServerComman=
dLine.java:76)
>     at org.apache.hadoop.hbase.master.HMaster.main(HMaster.java:1512)
> {code}
> In org.apache.hadoop.hbase.master.HMaster.HMaster(Configuration conf), we=
 have:
> {code}
> this.conf.setFloat(CacheConfig.HFILE_BLOCK_CACHE_SIZE_KEY, 0.0f);
> {code}
> When CacheConfig is instantiated, the following is called:
> {code}
> org.apache.hadoop.hbase.io.hfile.CacheConfig.instantiateBlockCache(Config=
uration conf)
> {code}
> Since "hfile.block.cache.size" is 0.0, instantiateBlockCache() would retu=
rn null, resulting in blockCache field of CacheConfig to be null.
> When master closes Root region, org.apache.hadoop.hbase.io.hfile.HFileRea=
derV1.close(boolean evictOnClose) would be called. cacheConf.getBlockCache(=
) returns null, leading to master abort.
> The following should be called in HFileReaderV1.close(), similar to the c=
ode in HFileReaderV2.close():
> {code}
> if (evictOnClose && cacheConf.isBlockCacheEnabled())
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp=
a
For more information on JIRA, see: http://www.atlassian.com/software/jira