Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D7BA9055 for ; Mon, 12 Dec 2011 07:05:02 +0000 (UTC) Received: (qmail 6180 invoked by uid 500); 12 Dec 2011 07:05:01 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 6035 invoked by uid 500); 12 Dec 2011 07:05:01 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 6015 invoked by uid 99); 12 Dec 2011 07:05:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2011 07:05:00 +0000 X-ASF-Spam-Status: No, hits=-2001.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2011 07:04:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id D150895DE8 for ; Mon, 12 Dec 2011 07:04:30 +0000 (UTC) Date: Mon, 12 Dec 2011 07:04:30 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <677990908.667.1323673470859.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <723793171.62431.1323582940140.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5007) HBaseAdmin.stopRegionServer do not stop the region server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5007?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1316= 7383#comment-13167383 ]=20 Hudson commented on HBASE-5007: ------------------------------- Integrated in HBase-0.92-security #36 (See [https://builds.apache.org/job/H= Base-0.92-security/36/]) HBASE-5007 HBaseAdmin.stopRegionServer do not stop the region server stack :=20 Files :=20 * /hbase/branches/0.92/CHANGES.txt * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInt= erface.java =20 > HBaseAdmin.stopRegionServer do not stop the region server > --------------------------------------------------------- > > Key: HBASE-5007 > URL: https://issues.apache.org/jira/browse/HBASE-5007 > Project: HBase > Issue Type: Bug > Components: ipc > Affects Versions: 0.92.0 > Environment: all > Reporter: honghua zhu > Fix For: 0.92.0 > > Attachments: HBase_0.92_HBASE-5007.patch > > > Please running this example: > public class Test { > public static void main(String[] args) throws Exception { > HBaseAdmin admin =3D new HBaseAdmin(HBaseConfiguration.create()); > admin.stopRegionServer("your.rs.hostname:60020"); > } > } > then, you can see: > Exception in thread "main" java.lang.RuntimeException: The interface org.= apache.hadoop.hbase.Stoppable > at org.apache.hadoop.hbase.ipc.Invocation.(Invocation.java:61) > at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Invoker.invoke(Writa= bleRpcEngine.java:151) > at $Proxy2.stop(Unknown Source) > at org.apache.hadoop.hbase.client.HBaseAdmin.stopRegionServer(HBaseAd= min.java:1492) > at Test.main(Test.java:7) > Caused by: java.lang.NoSuchFieldException: VERSION > at java.lang.Class.getField(Class.java:1520) > at org.apache.hadoop.hbase.ipc.Invocation.(Invocation.java:57) > ... 4 more > When invoking the "HBaseAdmin.stopRegionServer" method=EF=BC=8C > we obtain a "proxy" for org.apache.hadoop.hbase.ipc.HRegionInterface=EF= =BC=8C > (HRegionInterface extends org.apache.hadoop.hbase.Stoppable) > but the "stop" method declared in Stoppable. > In the constructor of "org.apache.hadoop.hbase.ipc.Invocation"=EF=BC=8C > the "method" argument is "public abstract void org.apache.hadoop.hbase.St= oppable.stop(java.lang.String)"=EF=BC=8C > so, "method.getDeclaringClass()" is "org.apache.hadoop.hbase.Stoppable"= =EF=BC=8C > but, the "Stoppable" interface no "VERSION" field. > [fix suggestion]: > Override the "stop" method in org.apache.hadoop.hbase.ipc.HRegionInterfac= e as follows: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > @Override > public void stop(String why); > of courese, another attempt is ok. > (e.g. declare "VERSION" field in Stoppable interface=EF=BC=8C > then modify some code fragment of Invocation and org.apache.hadoop.hbase.= ipc.WritableRpcEngine.Server) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira