Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 25 Dec 2011 17:54:32 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: 
 <491898964.44727.1324835672258.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <380028256.48122.1313650167694.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-4224) Need a flush by regionserver rather
 than by table option
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175844#comment-13175844 ] 

jiraposter@reviews.apache.org commented on HBASE-4224:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3308/#review4116
-----------------------------------------------------------


Please give us some results from testing in cluster.


/src/main/java/org/apache/hadoop/hbase/ServerName.java
<https://reviews.apache.org/r/3308/#comment9269>

    I think we should perform stricter checking on hostname, without using DNS.
    See http://regexlib.com/DisplayPatterns.aspx?cattabindex=1&categoryId=2&AspxAutoDetectCookieSupport=1


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9270>

    The 'execute' after 'the' should be removed.


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9271>

    The ctor with ThreadFactory parameter should be used so that threads in this pool can have names.


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9272>

    Second component should read 'all regions on a region server'


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9273>

    serverRegionsMap might be null upon return.
    I don't see null check below.


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9274>

    Should read 'every region server'


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9275>

    Should read 'whose WAL'


/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/3308/#comment9276>

    I think Future.get(long timeout, TimeUnit unit) should be used here so that we don't wait indefinitely.


- Ted


On 2011-12-24 04:31:50, Akash  Ashok wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3308/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-24 04:31:50)
bq.  
bq.  
bq.  Review request for hbase.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Flush by RegionServer
bq.  
bq.  
bq.  This addresses bug HBase-4224.
bq.      https://issues.apache.org/jira/browse/HBase-4224
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /src/main/java/org/apache/hadoop/hbase/ServerName.java 1222902 
bq.    /src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1222902 
bq.    /src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 1222902 
bq.    /src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1222902 
bq.  
bq.  Diff: https://reviews.apache.org/r/3308/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Akash
bq.  
bq.


> Need a flush by regionserver rather than by table option
> --------------------------------------------------------
>
>                 Key: HBASE-4224
>                 URL: https://issues.apache.org/jira/browse/HBASE-4224
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: stack
>            Assignee: Akash Ashok
>         Attachments: HBase-4224-v2.patch, HBase-4224.patch
>
>
> This evening needed to clean out logs on the cluster.  logs are by regionserver.  to let go of logs, we need to have all edits emptied from memory.  only flush is by table or region.  We need to be able to flush the regionserver.  Need to add this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira