Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EA6EB7719 for ; Fri, 23 Dec 2011 05:13:54 +0000 (UTC) Received: (qmail 72518 invoked by uid 500); 23 Dec 2011 05:13:54 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 72401 invoked by uid 500); 23 Dec 2011 05:13:53 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 72393 invoked by uid 99); 23 Dec 2011 05:13:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2011 05:13:52 +0000 X-ASF-Spam-Status: No, hits=-2002.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2011 05:13:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id AF00E124898 for ; Fri, 23 Dec 2011 05:13:30 +0000 (UTC) Date: Fri, 23 Dec 2011 05:13:30 +0000 (UTC) From: "Jieshan Bean (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <41814820.41667.1324617210718.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1721564786.38031.1324527570629.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5088) A concurrency issue on SoftValueSortedMap MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175283#comment-13175283 ] Jieshan Bean commented on HBASE-5088: ------------------------------------- +1 Use the concrete Map type is always not recommended. > A concurrency issue on SoftValueSortedMap > ----------------------------------------- > > Key: HBASE-5088 > URL: https://issues.apache.org/jira/browse/HBASE-5088 > Project: HBase > Issue Type: Bug > Components: client > Affects Versions: 0.90.4, 0.94.0 > Reporter: Jieshan Bean > Assignee: Jieshan Bean > > SoftValueSortedMap is backed by a TreeMap. All the methods in this class are synchronized. If we use this method to add/delete elements, it's ok. > But in HConnectionManager#getCachedLocation, it use headMap to get a view from SoftValueSortedMap#internalMap. Once we operate > on this view map(like add/delete) in other threads, a concurrency issue may occur. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira