Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 71EDB9F3E for ; Tue, 20 Dec 2011 19:46:55 +0000 (UTC) Received: (qmail 2940 invoked by uid 500); 20 Dec 2011 19:46:55 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 2911 invoked by uid 500); 20 Dec 2011 19:46:55 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 2903 invoked by uid 99); 20 Dec 2011 19:46:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2011 19:46:55 +0000 X-ASF-Spam-Status: No, hits=-2002.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2011 19:46:52 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 358F411E575 for ; Tue, 20 Dec 2011 19:46:31 +0000 (UTC) Date: Tue, 20 Dec 2011 19:46:31 +0000 (UTC) From: "Phabricator (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <299206251.32194.1324410391220.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1709918120.13317.1323905971152.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-5033) Opening/Closing store in parallel to reduce region open/close time MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173460#comment-13173460 ] Phabricator commented on HBASE-5033: ------------------------------------ lhofhansl has commented on the revision "[jira][HBASE-5033][[89-fb]]Opening/Closing store in parallel to reduce region open/close time". Looks good then. Thanks for the explanation. Also please see my comment on the jira (this is only helping with request latency and might possibly be detrimental to aggregate throughput). INLINE COMMENTS src/main/java/org/apache/hadoop/hbase/regionserver/Store.java:294 Oops... Didn't see ...storeOpener vs ...storeFileOpener. I think traditionally we'd name them store.opener... and storefile.opener... src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:814 Since the threadpool is shutdown in a finally clause it is probably ok. REVISION DETAIL https://reviews.facebook.net/D933 > Opening/Closing store in parallel to reduce region open/close time > ------------------------------------------------------------------ > > Key: HBASE-5033 > URL: https://issues.apache.org/jira/browse/HBASE-5033 > Project: HBase > Issue Type: Improvement > Reporter: Liyin Tang > Assignee: Liyin Tang > Attachments: D933.1.patch, D933.2.patch, D933.3.patch > > > Region servers are opening/closing each store and each store file for every store in sequential fashion, which may cause inefficiency to open/close regions. > So this diff is to open/close each store in parallel in order to reduce region open/close time. Also it would help to reduce the cluster restart time. > 1) Opening each store in parallel > 2) Loading each store file for every store in parallel > 3) Closing each store in parallel > 4) Closing each store file for every store in parallel. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira