Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4E977A61 for ; Fri, 9 Dec 2011 02:32:03 +0000 (UTC) Received: (qmail 81174 invoked by uid 500); 9 Dec 2011 02:32:03 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 81133 invoked by uid 500); 9 Dec 2011 02:32:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 81125 invoked by uid 99); 9 Dec 2011 02:32:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 02:32:03 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2011 02:32:01 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 18707108DBC for ; Fri, 9 Dec 2011 02:31:40 +0000 (UTC) Date: Fri, 9 Dec 2011 02:31:40 +0000 (UTC) From: "ramkrishna.s.vasudevan (Commented) (JIRA)" To: issues@hbase.apache.org Message-ID: <2141344423.56141.1323397900101.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <353325440.16206.1322457519964.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HBASE-4880) Region is on service before openRegionHandler completes, may cause data loss MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165783#comment-13165783 ] ramkrishna.s.vasudevan commented on HBASE-4880: ----------------------------------------------- +1 on patch. > Region is on service before openRegionHandler completes, may cause data loss > ---------------------------------------------------------------------------- > > Key: HBASE-4880 > URL: https://issues.apache.org/jira/browse/HBASE-4880 > Project: HBase > Issue Type: Bug > Affects Versions: 0.92.0, 0.94.0 > Reporter: chunhui shen > Assignee: chunhui shen > Attachments: 4880.txt, hbase-4880.patch, hbase-4880v2.patch, hbase-4880v3.patch, hbase-4880v4.patch > > > OpenRegionHandler in regionserver is processed as the following steps: > {code} > 1.openregion()(Through it, closed = false, closing = false) > 2.addToOnlineRegions(region) > 3.update .meta. table > 4.update ZK's node state to RS_ZK_REGION_OPEND > {code} > We can find that region is on service before Step 4. > It means client could put data to this region after step 3. > What will happen if step 4 is failed processing? > It will execute OpenRegionHandler#cleanupFailedOpen which will do closing region, and master assign this region to another regionserver. > If closing region is failed, the data which is put between step 3 and step 4 may loss, because the region has been opend on another regionserver and be put new data. Therefore, it may not be recoverd through replayRecoveredEdit() because the edit's LogSeqId is smaller than current region SeqId. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira