Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 75DBD9028 for ; Fri, 16 Dec 2011 21:57:03 +0000 (UTC) Received: (qmail 53773 invoked by uid 500); 16 Dec 2011 21:57:03 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 53734 invoked by uid 500); 16 Dec 2011 21:57:03 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 53707 invoked by uid 99); 16 Dec 2011 21:57:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Dec 2011 21:57:03 +0000 X-ASF-Spam-Status: No, hits=-2001.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Dec 2011 21:56:53 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E98E711705E for ; Fri, 16 Dec 2011 21:56:31 +0000 (UTC) Date: Fri, 16 Dec 2011 21:56:31 +0000 (UTC) From: "nkeywal (Updated) (JIRA)" To: issues@hbase.apache.org Message-ID: <2004103135.20873.1324072591957.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1916431866.19348.1324040310579.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HBASE-5053) HCM Tests leaks connections MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-5053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nkeywal updated HBASE-5053: --------------------------- Attachment: 5053.v2.patch > HCM Tests leaks connections > --------------------------- > > Key: HBASE-5053 > URL: https://issues.apache.org/jira/browse/HBASE-5053 > Project: HBase > Issue Type: Bug > Components: test > Affects Versions: 0.94.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Attachments: 5053.patch, 5053.v2.patch, 5053.v2.patch > > > There are simple leaks and one more complex. > The complex one comes from the fact fact HConnectionManager.HConnectionImplementation keeps a *reference* to the configuration used for the creation. So if this configuration is updated later, the HConnectionKey created initially will differ from the current one. As a consequence, the close() will not find the connection anymore in the list, and the connection won't be deleted. > I added a warning when a close does not find the connection in the list; but I wonder if we should not copy the HConnectionKey instead of keeping a reference. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira